Redline: sessions, review details on the PDF, and a UX rebuilt around a popover + a session window #30

Open
kua-agent wants to merge 5 commits from feat/redline-sessions-ux-20261031 into main
Member

What this changes

Sessions are the product now.
Every review is a session that is kept by default. The fixed 10-session cap is gone; an age limit (Never / 7 / 14 / 30 / 90 / 180 / 365 days) is chosen in Settings > Sessions and applied on launch, after archiving, and by Clean Up Now. Sent PDFs are never touched.

Each session records what it reviewed.
Lane/environment, deployed version, commit, reviewer (pre-filled from the Mac account) and a free note. They persist in session.json, are inherited by the next session, and are printed on the PDF.

Files and PDF metadata.
Redline---.pdf — sortable, unique per session, readable in Finder. Every page carries a two-line footer (tool, build time, session / lane, deployed build, commit, reviewer, note) and the PDF's document info carries the same values in Author and Keywords.

UX rebuilt from scratch (design mockups in design/ux-rework/).

  • Menu-bar popover: current session only — details as one line with an edit pencil, at most three thumbnails, Capture + Send, New Session + Open Redline, one status line, footer with channel, retention and a further-actions menu.
  • Redline window: sidebar of sessions grouped by day with state and a Current tag, pages as cards in the middle, inspector with editable review details, PDF facts and session facts; past sessions read-only.
  • Settings: three labelled groups (Capture, Sending, Sessions).

Verification

  • swift test --no-parallel: 159 tests pass.
  • scripts/run-selftest.sh panel: headless self-test against an isolated store — window lays out, details persist, PDF name/document info/footer correct, New Session keeps and inherits, grouping, age-limit cleanup keeps the sent PDF.
  • scripts/run-e2e-ui.sh: end-to-end against the active app (separate bundle id, isolated storage). Opens the real window, types into the Lane field with key events, activates New Session, checks disk state. It records honestly what a LaunchServices launch cannot deliver: synthetic HID clicks on window buttons have no effect and the SwiftUI text binding does not commit from synthesised keys, so those two paths are covered by the headless self-test and the unit tests instead.
  • scripts/render-panels.sh: renders of every surface plus a sample PDF, inspected during development.

Not in this PR

No release, no appcast change, no install over /Applications/Redline.app. Info.plist is bumped to 0.5.0 (build 7) so the next release carries the version.

## What this changes **Sessions are the product now.** Every review is a session that is kept by default. The fixed 10-session cap is gone; an age limit (Never / 7 / 14 / 30 / 90 / 180 / 365 days) is chosen in Settings > Sessions and applied on launch, after archiving, and by Clean Up Now. Sent PDFs are never touched. **Each session records what it reviewed.** Lane/environment, deployed version, commit, reviewer (pre-filled from the Mac account) and a free note. They persist in session.json, are inherited by the next session, and are printed on the PDF. **Files and PDF metadata.** Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf — sortable, unique per session, readable in Finder. Every page carries a two-line footer (tool, build time, session / lane, deployed build, commit, reviewer, note) and the PDF's document info carries the same values in Author and Keywords. **UX rebuilt from scratch** (design mockups in design/ux-rework/). - Menu-bar popover: current session only — details as one line with an edit pencil, at most three thumbnails, Capture + Send, New Session + Open Redline, one status line, footer with channel, retention and a further-actions menu. - Redline window: sidebar of sessions grouped by day with state and a Current tag, pages as cards in the middle, inspector with editable review details, PDF facts and session facts; past sessions read-only. - Settings: three labelled groups (Capture, Sending, Sessions). ## Verification - swift test --no-parallel: 159 tests pass. - scripts/run-selftest.sh panel: headless self-test against an isolated store — window lays out, details persist, PDF name/document info/footer correct, New Session keeps and inherits, grouping, age-limit cleanup keeps the sent PDF. - scripts/run-e2e-ui.sh: end-to-end against the active app (separate bundle id, isolated storage). Opens the real window, types into the Lane field with key events, activates New Session, checks disk state. It records honestly what a LaunchServices launch cannot deliver: synthetic HID clicks on window buttons have no effect and the SwiftUI text binding does not commit from synthesised keys, so those two paths are covered by the headless self-test and the unit tests instead. - scripts/render-panels.sh: renders of every surface plus a sample PDF, inspected during development. ## Not in this PR No release, no appcast change, no install over /Applications/Redline.app. Info.plist is bumped to 0.5.0 (build 7) so the next release carries the version.
kua-agent added 3 commits 2026-10-31 09:04:43 +00:00
Sessions are now the unit of the product instead of an implicit capture run.

- Nothing is deleted by default: the fixed 10-session cap is gone. An age limit
  (Never / 7 / 14 / 30 / 90 / 180 / 365 days) is chosen in Settings > Sessions and
  applied on launch, after archiving, and by "Clean up now". Sent PDFs are never
  touched.
- Each session carries review details: lane, deployed version, commit, reviewer
  (pre-filled with the Mac user) and a free note. They persist in session.json and
  are inherited by the next session, so a review run is typed once.
- PDF file names are Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf, and every page
  carries a two-line reference footer (tool, build time, session / lane, deployed
  build, commit, reviewer, note). The PDF document info carries the same values in
  Author and Keywords.
- Verification: 159 tests, a headless panel self-test, and a LaunchServices-driven
  end-to-end run that types and clicks the real panel.
The menu-bar popover was being used as a session manager: status, five text fields,
thumbnails, three buttons, a history list and eight more flat rows in 320 pt. The
redesign splits the product by job, from a UX pass whose mockups are kept under
design/ux-rework/.

- Popover: only the current session. Review details as one line plus a pencil that
  opens the window with the Lane field focused, at most three thumbnails, a Capture
  and a Send row, a New Session and Open Redline row, one status line when something
  happened, and a footer with the send channel, the retention policy and a ... menu
  for Settings / updates / quit.
- Window: sidebar of sessions grouped Today / Yesterday / This week / by month with
  a Current tag and each session's state, the selected session's pages as cards
  (select, Delete or Remove Page, sent sessions read-only), and an inspector with
  editable review details, the PDF facts (file name, pages, channel, status) and the
  session facts (started, id, files). Past sessions show their details read-only.
- Settings: three labelled groups (Capture, Sending, Sessions) replacing the
  headings-plus-grid layout.
- Sessions list/search/grouping/state live on the model, so the window and the popover
  read the same truth (came-back-marked state comes from the return ledger).
- Verification: 159 tests, the headless panel self-test, and an end-to-end run against
  the active app (scripts/run-e2e-ui.sh) which opens the real window, types into the
  Lane field with key events and clicks New Session, reporting what the launch mode
  could and could not deliver.
kua-agent added 1 commit 2026-11-01 04:41:05 +00:00
--window opens the Redline window at launch, so a script or a demo lands on the new UI instead of an idle menu-bar icon. Clicking the running app in Finder, or open -a Redline, now shows the window instead of doing nothing. scripts/install-local.sh installs the locally built app into /Applications, keeps the previous copy at .build/Redline-<version>.app for rollback, and launches it with the window open.
kua-agent added 1 commit 2026-11-01 07:48:02 +00:00
Capture is now a decision, not a hidden setting. The popover shows a four-way scope control with the target named under it (800 x 600 on Display 1, the frontmost window, the front browser window, the whole display), and the window header carries the same choice beside the verbs. Picking Window or Browser hides Redline, dims the screen, names the app under the pointer and highlights its window; a click captures exactly that window, Escape cancels, and the desktop highlights the whole screen. New Session is one click: the current captures stay in their own folder, a fresh session opens, and the area picker comes straight up with the saved area pre-selected — Return keeps it, a drag replaces it. Settings is consolidated into one door (the popover gear, plus Cmd-,): what to capture, saved area, shortcut, ask-on-new-session, sending, session age limit, and a new Updates group with automatic install (on by default; installs only when nothing is unsent). The footer filler and the extra-actions menu are gone.
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/redline-sessions-ux-20261031:feat/redline-sessions-ux-20261031
git checkout feat/redline-sessions-ux-20261031
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mmd-it/shotdeck#30