ReturnWatcherTests.swift: two new tests bracket the BLOCKER fix — one characterizes the old bug (FolderSettings.resolvedAppSupportPaths(), AirDrop- only, ignores the persisted OneDrive transport; the watcher ends up watching a stale isolated folder and misses a marked PDF dropped into the real OneDrive-mode folder), the other proves the fix (the exact launch/bootstrap construction — TransportSettings.resolvedAppSupportPaths() + watcher.updateWatchFolder() before start — detects it). Both isolated to temp dirs, including an explicit FolderSettings watch-folder override so the "bug" test's found.isEmpty assertion never depends on what's actually in Ben's real ~/Downloads (it does, in fact, already contain real marked-up Redline PDFs from prior testing — an earlier version of this test read the REAL Downloads folder and failed for exactly that reason). TransportSettingsTests.swift: three tests for OneDriveLocator.isWritableDirectory — true for an ordinary directory, false for one chmod'd 500 (permissions restored in teardown before removal), false for a plain file and for a nonexistent path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ZiTXPbPCSjzPVsfoweAbp
147 lines
5.8 KiB
Swift
147 lines
5.8 KiB
Swift
import Foundation
|
|
import Testing
|
|
import ShotdeckCore
|
|
|
|
@Test
|
|
func transportDefaultsToAirDropWhenUnset() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
|
|
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
|
}
|
|
|
|
@Test
|
|
func setTransportRoundTrips() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
|
|
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
|
#expect(TransportSettings.transport(defaults: suite.defaults) == .oneDrive)
|
|
|
|
TransportSettings.setTransport(.airDrop, defaults: suite.defaults)
|
|
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
|
}
|
|
|
|
@Test
|
|
func garbageStoredTransportFallsBackToAirDrop() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
|
|
suite.defaults.set("not-a-real-transport", forKey: TransportSettings.transportDefaultsKey)
|
|
#expect(TransportSettings.transport(defaults: suite.defaults) == .airDrop)
|
|
}
|
|
|
|
@Test
|
|
func oneDriveFolderStoreAndReset() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
let folder = try makeTransportTemporaryDirectory(prefix: "shotdeck-onedrive-folder")
|
|
defer { try? FileManager.default.removeItem(at: folder) }
|
|
|
|
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == nil)
|
|
|
|
TransportSettings.setOneDriveFolder(folder, defaults: suite.defaults)
|
|
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == folder.path)
|
|
|
|
TransportSettings.resetOneDriveFolder(defaults: suite.defaults)
|
|
#expect(TransportSettings.storedOneDriveFolderPath(defaults: suite.defaults) == nil)
|
|
}
|
|
|
|
@Test
|
|
func effectiveFoldersForAirDropMatchesFolderSettings() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
let outbox = try makeTransportTemporaryDirectory(prefix: "shotdeck-effective-outbox")
|
|
defer { try? FileManager.default.removeItem(at: outbox) }
|
|
FolderSettings.setOutbox(outbox, defaults: suite.defaults)
|
|
|
|
let effective = TransportSettings.effectiveFolders(defaults: suite.defaults)
|
|
let expected = FolderSettings.resolve(defaults: suite.defaults)
|
|
|
|
#expect(effective.transport == .airDrop)
|
|
#expect(effective.outbox.path == expected.outbox.path)
|
|
#expect(effective.watch.path == expected.watch.path)
|
|
}
|
|
|
|
@Test
|
|
func effectiveFoldersForOneDriveWithAResolvableFolderUsesItForBoth() throws {
|
|
let suite = try makeTransportDefaultsSuite()
|
|
defer { tearDownTransportSuite(suite) }
|
|
let folder = try makeTransportTemporaryDirectory(prefix: "shotdeck-effective-onedrive")
|
|
defer { try? FileManager.default.removeItem(at: folder) }
|
|
|
|
TransportSettings.setTransport(.oneDrive, defaults: suite.defaults)
|
|
TransportSettings.setOneDriveFolder(folder, defaults: suite.defaults)
|
|
|
|
let effective = TransportSettings.effectiveFolders(defaults: suite.defaults)
|
|
|
|
#expect(effective.transport == .oneDrive)
|
|
#expect(effective.outbox.path == folder.path)
|
|
#expect(effective.watch.path == folder.path)
|
|
#expect(effective.outbox.path == effective.watch.path)
|
|
}
|
|
|
|
@Test
|
|
func oneDriveFolderUnavailableErrorDescriptionContainsThePath() throws {
|
|
let path = "/Users/example/Library/CloudStorage/OneDrive-Example/Redline"
|
|
let error = ShotdeckError.oneDriveFolderUnavailable(path: path)
|
|
let description = try #require(error.errorDescription)
|
|
#expect(!description.isEmpty)
|
|
#expect(description.contains(path))
|
|
}
|
|
|
|
@Test
|
|
func isWritableDirectoryTrueForAnOrdinaryWritableDirectory() throws {
|
|
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-writable")
|
|
defer { try? FileManager.default.removeItem(at: dir) }
|
|
#expect(OneDriveLocator.isWritableDirectory(at: dir))
|
|
}
|
|
|
|
@Test
|
|
func isWritableDirectoryFalseForAnExistingButUnwritableDirectory() throws {
|
|
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-unwritable")
|
|
defer {
|
|
// Restore perms BEFORE removal — an unwritable dir can't otherwise be cleaned up.
|
|
try? FileManager.default.setAttributes([.posixPermissions: 0o755], ofItemAtPath: dir.path)
|
|
try? FileManager.default.removeItem(at: dir)
|
|
}
|
|
#expect(OneDriveLocator.isWritableDirectory(at: dir)) // sanity check before chmod
|
|
|
|
try FileManager.default.setAttributes([.posixPermissions: 0o500], ofItemAtPath: dir.path)
|
|
#expect(!OneDriveLocator.isWritableDirectory(at: dir))
|
|
}
|
|
|
|
@Test
|
|
func isWritableDirectoryFalseForAPlainFileAndForANonexistentPath() throws {
|
|
let dir = try makeTransportTemporaryDirectory(prefix: "shotdeck-writable-check-parent")
|
|
defer { try? FileManager.default.removeItem(at: dir) }
|
|
let filePath = dir.appendingPathComponent("plain-file.txt")
|
|
FileManager.default.createFile(atPath: filePath.path, contents: Data("x".utf8))
|
|
|
|
#expect(!OneDriveLocator.isWritableDirectory(at: filePath))
|
|
#expect(!OneDriveLocator.isWritableDirectory(at: dir.appendingPathComponent("does-not-exist")))
|
|
}
|
|
|
|
struct TransportDefaultsSuite {
|
|
let name: String
|
|
let defaults: UserDefaults
|
|
}
|
|
|
|
func makeTransportDefaultsSuite() throws -> TransportDefaultsSuite {
|
|
let name = "shotdeck-transport-test-\(UUID().uuidString)"
|
|
let defaults = try #require(UserDefaults(suiteName: name))
|
|
defaults.removePersistentDomain(forName: name)
|
|
return TransportDefaultsSuite(name: name, defaults: defaults)
|
|
}
|
|
|
|
func tearDownTransportSuite(_ suite: TransportDefaultsSuite) {
|
|
suite.defaults.removePersistentDomain(forName: suite.name)
|
|
}
|
|
|
|
func makeTransportTemporaryDirectory(prefix: String) throws -> URL {
|
|
let url = FileManager.default.temporaryDirectory
|
|
.appendingPathComponent("\(prefix)-\(UUID().uuidString)", isDirectory: true)
|
|
try FileManager.default.createDirectory(at: url, withIntermediateDirectories: true)
|
|
return url
|
|
}
|