Sessions are now the unit of the product instead of an implicit capture run.
- Nothing is deleted by default: the fixed 10-session cap is gone. An age limit
(Never / 7 / 14 / 30 / 90 / 180 / 365 days) is chosen in Settings > Sessions and
applied on launch, after archiving, and by "Clean up now". Sent PDFs are never
touched.
- Each session carries review details: lane, deployed version, commit, reviewer
(pre-filled with the Mac user) and a free note. They persist in session.json and
are inherited by the next session, so a review run is typed once.
- PDF file names are Redline-<yyyyMMdd-HHmm>-<LANE>-<SHORTID>.pdf, and every page
carries a two-line reference footer (tool, build time, session / lane, deployed
build, commit, reviewer, note). The PDF document info carries the same values in
Author and Keywords.
- Verification: 159 tests, a headless panel self-test, and a LaunchServices-driven
end-to-end run that types and clicks the real panel.
Round 2 of adversarial review confirmed defects 2,3,4,5,7 fixed and
raised three new ones; all three are fixed here, plus the guard-message
nit.
NEW-1 (the FAIL driver): the OneDrive send path overwrote the truthful
status from handleDidShareItems with its own success text, silently
dropping an archive failure and any state-refresh problem. The seam now
takes the caller's success summary and composes ONE truthful message:
summary (the share itself did complete) + archive error if any + refresh
problems if any. Both callers (AirDrop delegate, OneDrive) pass their
summary; the OneDrive text is never clobbered.
NEW-2: if the replacement open session could not be created after the
archive rename (disk full), the store kept reporting the already-archived
session as the open one. SpoolStore now has a truth guard
(ensureOpenSession): the open session is verified to really exist on disk
and be in state .open before any read/mutate; a stale one is replaced by
a genuinely fresh session, or the call fails loudly. Never a lie.
NEW-3: archivedSessions() read the folder tie-break dates AFTER
reconciliation, so a healed same-second session could bump its own
modification date and outrank a genuinely newer peer. The dates are now
read BEFORE reconciling.
Nit: the startNewSession guard now reports "A new session is already
being started." when the refusal is about a concurrent session start,
not a send.
Also added REDLINE_SELFTEST_PHASE=sendtruth (mirroring the existing
=onedrive escape hatch) so the SEND-TRUTH selftest can run without the
picker chain's display-dependent REGION-PERSIST phase.
Evidence: 136 swift tests pass (2 new: OneDrive summary survives
archiving; stale open session never returned as current).
REDLINE_SELFTEST_PHASE=sendtruth -> SEND-TRUTH PASS.
REDLINE_SELFTEST_PHASE=onedrive -> ONEDRIVE-SELFTEST PASS against the
real OneDrive sync root.
MMDB-2925. Two new menu functions in the Redline app:
- "Start new session" keeps the current screenshots as a past session
(moved into the single archive/ folder — never deleted on close) and
opens a fresh empty session. Sessions closed without ever sending keep
pdfFileName nil and show as "Not sent" in the list.
- "Past submissions…" opens a window listing every retained session
(timestamp, page count, what was sent) with actions to reveal the sent
PDF and the session's screenshot folder.
Retention (Ben's rule 2026-10-11: "retain the past 10 sessions"): both
archive paths (send and close) keep the newest 10 archived session
folders in archive/ and remove the rest. Any PDF a pruned session
produced is untouched — it lives in the outbox/OneDrive folder.
archivedSessions() ordering now tie-breaks same-second sessions by the
session folder's creation date, so listing and pruning are deterministic
(manifest timestamps are whole-second ISO8601 — format pinned in
AtomicFileTests).
Tests: 6 core tests in SessionRetentionTests (close/keep/reconcile,
sent-vs-unsent, retention of 10, explicit prune, send-path retention) and
3 app-target tests in SessionWorkflowTests driving the real AppModel menu
actions through AppDelegate.makeLaunchModel(). PanelSnapshot renders the
new window as panel-06b-past-submissions.png.